dd: warn when skip goes past the end of the input file#13115
Open
eyupcanakman wants to merge 1 commit into
Open
dd: warn when skip goes past the end of the input file#13115eyupcanakman wants to merge 1 commit into
eyupcanakman wants to merge 1 commit into
Conversation
The File source seeked without checking the resulting offset against the file size, so dd did not print GNU's "cannot skip to specified offset" message. Add the check the seekable-stdin path already has, and guard both arms so an empty file stays silent, matching GNU. Closes uutils#13047
|
GNU testsuite comparison: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dd if=FILE skip=Npast the end of FILE did not print GNU'scannot skip to specified offset. TheFilesource now checks the seek result.Closes #13047